Obtainment methods for every Pokémon in every game - #5

- PR bodies drifted in shape across `#3`, `#5`, and `#6` — bullets in two,
  bold-lead paragraphs in the third, section names picked per PR
- skill fixes the contract: lede, `## What changed`, `## Verification`,
  `## Notes`, with per-subsystem sections when the change spans several
- bullets are the default form; prose is confined to the lede
- title rules mirror the commit-subject style already in `git log`
- `--body-file` is required, not preferred: backticks inside a
  double-quoted `--body` string are executed by the shell
- carries `CLAUDE.md`'s zero-AI-attribution rule into PR titles and bodies

- both skills previously banned prefixes outright, matching the 60 commits
  measured at the time — that rule is now reversed by convention
- `PMX: ` is mandatory on every hand-written commit subject and PR title
- form follows the sister repo's `CJR:` convention: code, colon, one space
- pokemax capitalizes the first word after the prefix; `codebender-portfolio`
  lowercases it, so the two repos differ past the colon
- version bumps take the prefix too — `PMX: 0.3.4`
- `(#5)` squash suffixes still come from GitHub, never typed by hand
- this subject is the first commit written under the new rule

- PR bodies drifted in shape across `#3`, `#5`, and `#6` — bullets in two,
  bold-lead paragraphs in the third, section names picked per PR
- skill fixes the contract: lede, `## What changed`, `## Verification`,
  `## Notes`, with per-subsystem sections when the change spans several
- bullets are the default form; prose is confined to the lede
- title rules mirror the commit-subject style already in `git log`
- `--body-file` is required, not preferred: backticks inside a
  double-quoted `--body` string are executed by the shell
- carries `CLAUDE.md`'s zero-AI-attribution rule into PR titles and bodies

- both skills previously banned prefixes outright, matching the 60 commits
  measured at the time — that rule is now reversed by convention
- `PMX: ` is mandatory on every hand-written commit subject and PR title
- form follows the sister repo's `CJR:` convention: code, colon, one space
- pokemax capitalizes the first word after the prefix; `codebender-portfolio`
  lowercases it, so the two repos differ past the colon
- version bumps take the prefix too — `PMX: 0.3.4`
- `(#5)` squash suffixes still come from GitHub, never typed by hand
- this subject is the first commit written under the new rule

* PMX: Drop always-true clause from `encountersToEntries`

- `METHOD_MAP` has no entry mapping to `'special'`
- so `method === 'special'` already implies `!METHOD_MAP[slug]`
- second clause could never be false when the first was true

* PMX: Make `isObtainFile` validate the shape its consumers index

- derive `ObtainMethod` from a new `OBTAIN_METHODS` list — one vocabulary
- guard now checks `games[].gen`/`versionGroup`/`versions`/`entries`
- rejects entries whose `method` is not a known method
- previously `ObtainMethods.tsx` indexed `METHOD_LABEL` on unvalidated strings
- verified all 1351 files in `public/obtain/` still pass

* PMX: Give the region model one owner in `generations.ts`

- new `REGIONS` + `REGION_OF_VERSION_GROUP` map every version group to its setting
- `GAMES_BY_REGION` now derives from `REGIONS` instead of restating it
- `ObtainMethods.tsx` drops `VG_REGION`, `REGION_ORDER`, `REGION_LABELS`
- kills the `getGen(gen).region` fallback, which was wrong for every remake
  and was the reason `VG_REGION` had to exist as a patch table
- Hisui's note comes from `REGIONS`, not a one-entry label override
- rename `crt-obtain-gen`/`crt-obtain-gen-toggle` — the rows are regions, not gens
- new `regions.test.ts` pins coverage and ordering against `GENERATIONS`

* PMX: Collapse the obtain loading contract into one status union

- `useObtainData` returns `ObtainState` — `idle` / `loading` / `error` / `ready`
- the enabled-but-not-yet-started frame now reports `loading` from the hook
- drops the compensating `loading || (enabled && !data && !error)` in the view
- drops the stale-id reconciliation — `settled.id` scopes failures to their id
- `ObtainMethods` takes `state` + `currentGen`, down from five props
- `enabled` no longer passed twice from `PokemonCard.tsx`
- ready branch split into `ObtainRegions` so the data is non-null by type
- loading/idle tests move to `useObtainData.test.ts` where the inputs live

* PMX: Drop the nullable expansion state from `ObtainRegions`

- `Set<string> | null` existed only because the default region was unknown
  until the file loaded — inside `ObtainRegions` it is known at mount
- plain `useState<Set<string>>` with a lazy initializer replaces it
- `toggle` no longer closes over a render-scoped `expanded` fallback
- not routed through `useExpandedRegions` on purpose: its persisted value
  would carry one Pokémon's open region onto the next

* PMX: Fold the condition tables into one `CONDITION_FAMILIES` model

- `CONDITION_PREFIXES`, `conditionMeta`'s if-chain, and `LEGEND_CONDITIONS`
  all dispatched on the same slug families — a new family meant three edits
- one table now carries prefix, icon, color, label strip, and legend gloss
- `LEGEND_CONDITIONS` derives from it instead of restating icon/color by hand
- `RODS` deleted — `ROD_METHODS` exported from `@/obtain/pokeapi` and shared
  by the build parser and the chip renderer
- diffed old vs new over all 341 condition slugs in `public/obtain/` — identical
- new test pins one chip per family, including the unknown-slug fallback

* PMX: Move the obtain display vocabulary into `src/obtain/labels.ts`

- `ObtainMethods.tsx` was 410 lines, ~250 of them static label tables
- `METHOD_LABEL`, `METHOD_COLOR`, `CONDITION_*`, `LEGEND_*`, `levelRate`,
  `prettyCondition`, `conditionMeta` now live beside the domain they describe
- component drops to 176 lines of rendering
- `regionLabel` takes `RegionMeta` instead of an ad-hoc object shape
- `LEGEND_CONDITIONS` uses `flatMap` so it narrows without `?? ''` padding
- new `obtainLabels.test.ts` pins label/color/gloss coverage to `OBTAIN_METHODS`

* PMX: Add a `create-pull-request` skill so PRs share one format

- PR bodies drifted in shape across `#3`, `#5`, and `#6` — bullets in two,
  bold-lead paragraphs in the third, section names picked per PR
- skill fixes the contract: lede, `## What changed`, `## Verification`,
  `## Notes`, with per-subsystem sections when the change spans several
- bullets are the default form; prose is confined to the lede
- title rules mirror the commit-subject style already in `git log`
- `--body-file` is required, not preferred: backticks inside a
  double-quoted `--body` string are executed by the shell
- carries `CLAUDE.md`'s zero-AI-attribution rule into PR titles and bodies

* PMX: Point `CLAUDE.md` at the `create-pull-request` skill

- line 13 claimed `pokemax-commit-format` governed "PR titles and bodies
  too" — two skills owning PR format is the drift the new skill removes
- that bullet now scopes to commit messages; a new bullet hands PR titles
  and bodies to `create-pull-request`
- both still carry the zero-AI-attribution rule, so narrowing one bullet
  does not open a gap

* PMX: Add the missing `pokemax-commit-format` skill, repo-local

- `CLAUDE.md` has mandated this skill since `e1a3761` but no file existed
  at the path it named, so the rule was unenforceable
- rules derived by measuring the last 60 commits, not invented: 188 body
  bullets, 0 ending in a period, 0 prose lines, subject median 53 chars
- lands in `.claude/skills/` beside `create-pull-request` rather than
  `~/.claude/skills/` — pokemax skills belong to the repo
- `CLAUDE.md` path updated to match; the `Don't` section reference needed
  no change since it names the skill without a path

* PMX: Cut duplicate CI runs and pin the toolchain in both workflows

- `ci.yml` ran on `push: branches: ['**']` and `pull_request`, so every
  commit on a PR branch triggered two identical full runs
- push now scopes to `main`; `pull_request` covers branch work
- `bun-version: latest` made CI non-deterministic — a bun release could
  break a green tree with no repo change; both workflows pin `1.4.0`,
  matching the local toolchain and the `.nvmrc`/`engines` pinning style
- `actions/cache@v4` on `~/.bun/install/cache`, keyed by `bun.lock`
- `ci.yml` gains `permissions: contents: read`; it inherited the repo
  default and needs no write scope
- `timeout-minutes` on all three jobs so a hung runner cannot burn minutes
- `workflow_dispatch` added to `ci.yml` for manual re-runs
- concurrency group keys on `github.workflow` too, so `ci.yml` and a future
  workflow on the same ref cannot cancel each other
- deploy keeps its own `test` step on purpose — `workflow_dispatch` can
  ship a commit CI never gated

* PMX: Require the `PMX:` repo-code prefix on commits and PRs

- both skills previously banned prefixes outright, matching the 60 commits
  measured at the time — that rule is now reversed by convention
- `PMX: ` is mandatory on every hand-written commit subject and PR title
- form follows the sister repo's `CJR:` convention: code, colon, one space
- pokemax capitalizes the first word after the prefix; `codebender-portfolio`
  lowercases it, so the two repos differ past the colon
- version bumps take the prefix too — `PMX: 0.3.4`
- `(#5)` squash suffixes still come from GitHub, never typed by hand
- this subject is the first commit written under the new rule

* PMX: Stop `.husky/pre-commit` failing docs-only commits

- `oxfmt` exits 2 when no staged file is a type it formats, printing to
  stderr and leaving stdout empty
- husky runs hooks under `set -e`, so the bare `unformatted=$(…)`
  assignment inherited that 2 and aborted the commit
- any commit staging only `.md`, `.svg`, or `.png` was blocked
- `|| true` on the assignment restores the intended behavior: no
  formattable files means nothing to reformat, so the hook exits 0
- latent since the hook was written; surfaced once `bun install` recreated
  `.husky/_` in this worktree and the hooks began running at all

* PMX: Rename `pokemax-commit-format` to `commit-format`

- the skill lives in the pokemax repo, so the repo name in the skill name
  was redundant — `.claude/skills/commit-format/`
- frontmatter `name:` and the `# Commit format` heading follow the path
- `CLAUDE.md` and `AGENTS.md` updated in both the Do and Don't sections
- `AGENTS.md` pointed at `~/.Codex/skills/pokemax-commit-format/SKILL.md`,
  which never existed; it now names the repo-local file like `CLAUDE.md`
- `docs/superpowers/plans/2026-07-31-obtainment-methods.md` still cites the
  old name and is left alone — it records what was true when it was written